phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008549phplist applicationMessage Send Processpublic16-11-06 09:1318-02-08 14:08
Reporterdanieleint 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version2.10.3 
Target Version2.10.7Fixed in Version2.10.5 
Summary0008549: message envelope not passed to php mailer, phpmailer does not set the correct Sender
DescriptionSe the summary and the patch.
Steps To ReproduceSend a newsletter using default values and set $message_envelope.
The message is sent with the wrong envelope sender.
TagsNo tags attached.
Attached Filespatch file icon set_envelope_with_phpmailer.patch [^] (1,638 bytes) 16-11-06 09:13 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0003721closed phplist 2.10.x 

-  Notes
(0021411)
hola (reporter)
26-11-06 21:02

hello - I am not sure why you are adding the new logic to phpmailer - if you look at the conditional that would invoke the code you changed the else is dealing with the Sender param not being sent

if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)
(0021765)
danieleint (reporter)
06-12-06 15:36

Hellp, hola is right.
The patch should be valid for the file lists/admin/lib.php
(0022107)
michiel (manager)
18-12-06 17:43

the use of ini_set("sendmail_from", $this->Sender);
in your patch suggests you're working on a windows system.
That makes it harder to test for me to see that it works.

So, am I correct to understand that you think that changing

if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)

in lib.php will fix it instead?
(0022112)
hola (reporter)
18-12-06 20:06

hmmm that code you mention Michiel was already in the phpmailer class - I doubled checked on your 2.10.3 release and here it is below

 if ($this->Sender != "" && strlen(ini_get("safe_mode"))< 1)
        {
            $old_from = ini_get("sendmail_from");
            ini_set("sendmail_from", $this->Sender);
            $params = sprintf("-oi -f %s", $this->Sender);
            $rt = @mail($to, $this->EncodeHeader($this->Subject), $body,
                        $header, $params);
        }
        else
            $rt = @mail($to, $this->EncodeHeader($this->Subject), $body, $header);
(0022113)
hola (reporter)
18-12-06 20:07

Can you please highlight why this would be an issue on non-windows platforms as I am running phplist on Linux
(0022116)
michiel (manager)
18-12-06 20:28

well, I don't get the problem on Linux at all, so to get it fixed, someone with windows will have to figure out how to fix it.
(0022117)
hola (reporter)
18-12-06 20:32

I don't even know what the problem is with phpmailer. I was just commenting on the fact that phpmailer already had the set_ini. I think I am missing something here... I will just watch from now on.
(0029870)
user1822
30-07-07 17:01

envelope included in mail object construction of PHPListMailer
Second patch was already like this.
This issues report is quite confusing, try to be more clear:
• What did you do (incl. platform)
• What did you expect
• What did you get


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker