View Issue Details

IDProjectCategoryView StatusLast Update
0008494phplist applicationMessage Managementpublic18-02-08 14:08
Reporterbhugh 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.2 
Target Version2.10.7Fixed in Version2.10.5 
Summary0008494: Once you "exclude" a list you can't "un-exclude" from that message
DescriptionUnder the "send a message" function, "lists" tab:

If you select a list to be excluded, then save the message or send the message, if you go back and try to "un-check" that list you have excluded so that it is no longer excluded, that change is not saved when you 'save changes' or 'send message' again.

Instead, if you go back to the 'lists' tab you discover that the exclude list that you have un-checked is still checked.

You can, however, select a different list as an exclude list and that option appears to be saved when you 'save changes' or 'send message'. What you can't do, however, remove *all* lists from the "lists to be excluded". The last one that is un-checked simply becomes checked again when you go back into the lists tab to view it.
TagsNo tags attached.

Relationships

related to 0003721 closed phplist 2.10.x 

Activities

user1308

24-07-07 13:01

  ~0029713

fixed. Changed this
if (isset($_POST["excludelist"]) && is_array($_POST["excludelist"])) {
      $exclude = join(",",$_POST["excludelist"]);
      Sql_Query(sprintf('replace into %s (name,id,data) values("excludelist",%d,"%s")',$tables["messagedata"],$messageid,$exclude));
    }


into this:

if (USE_LIST_EXCLUDE) {
    if (isset($_POST["excludelist"]) && is_array($_POST["excludelist"])) {
      $exclude = join(",",$_POST["excludelist"]);
      Sql_Query(sprintf('replace into %s (name,id,data) values("excludelist",%d,"%s")',$tables["messagedata"],$messageid,$exclude));
    } else {
      Sql_Query(sprintf('replace into %s (name,id,data) values("excludelist",%d,"%s")',$tables["messagedata"],$messageid,0));
    }
  }