View Issue Details

IDProjectCategoryView StatusLast Update
0008092phplist applicationStatisticspublic18-02-08 14:08
Reportervide 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.2 
Target Version2.10.7Fixed in Version2.10.3 
Summary0008092: Single quote hrefs not translated into tracked urls
DescriptionI'm using PHPList 2.10.2 and I've found that activating click tracking on links, links that are like href='mysite' doesn't get translated. You have to have double quotes as in href="mysite" to get them translated.
 
 I've found the "culpable" regexp in admin/sendemaillib.php line 361
 
 preg_match_all('/<a>]*)>(.*)</a>/Umis',$htmlmessage,$links);
 
 and I've changed it to:
 
 preg_match_all('/<a(.*)href=["\'](.*)["\']([^>]*)>(.*)</a>/Umis',$htmlmessage,$links);
 
 to match both single (') and double (") quotes.
TagsNo tags attached.

Relationships

related to 0003721 closed phplist 2.10.x 

Activities

vide

02-10-06 09:56

reporter   ~0019439

There is and identical bug in the stripHTML() function while converting the links in text mode:

(old)
#$text = preg_replace("/<a href=\"(.*?)\"[^>]*>(.*?)<\/a>/is","[URLTEXT]\\2[/URLTEXT][LINK]\\1[/LINK]",$text,100);

(new)
  $text = preg_replace("/<a href=[\"\'](.*?)[\"\'][^>]*>(.*?)<\/a>/is","[URLTEXT]\\2[/URLTEXT][LINK]\\1[/LINK]",$text,100);

always in sendemaillib.php line 818