0007418: Typo in rsslib.php

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1

View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007418

phplist application

RSS

public

17-08-06 14:30

18-02-08 14:16

Reporter

akolthoff

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

2.10.2

Target Version

2.10.7

Fixed in Version

2.10.3

Summary

0007418: Typo in rsslib.php

Description

Line 76 of the distribution file public_html/lists/admin/rsslib.php reads:

$treshold = getConfig("rsstheshold");

missing the 'r'. It must be corrected to:

$treshold = getConfig("rssthreshold");

Additional Information

Because of this typo the configured "Minimum amount of items to send in an RSS feed" always would be ignored.

I have noticed that in the MySQL database in the phplist_config table an item 'rsstheshold' (the wrong spelling) exists, additional to the correct 'rssthreshold' item.

Also there are inconsistencies regarding the spelling of "threshold" in several files; sometimes in strings and variable names it is spelled as "treshold", for instance here in processqueue.php:

$rss_content_treshold = sprintf('%d',getConfig("rssthreshold"));

For the sake of clarity this should be corrected.

Notes
(0017002) michiel (manager) 17-08-06 15:32	ah, that's a great find. thanks