View Issue Details

IDProjectCategoryView StatusLast Update
0006682phplist applicationInstallationpublic15-04-10 23:32
ReporterRothgar 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformUnixOSFreeBSDOS Version5.3
Product Version2.10.2 
Target VersionFixed in Version2.10.11 
Summary0006682: PHP Short Tags
DescriptionHi Guys,

Just installed PHP list and ran into a few problems since we have disabled PHP short tags to adopt the new standardization. Since PHP short tags can conflict with XML's short open tag we have disabled them.

For the most part PHP list seems like it's coded well and not using short tags, however there are a lot of perhaps updated pages which are now using short tags.

I have gone through what I found and changed them and for the most part seems to be running fine. Below are my changes so that perhaps they can be fixed for a new release and standardized to not use half short tags and half not.

EDIT "admin/massunconfirm.php" TO <?php

commonlib FOLDER
EDIT "/admin/commonlib/lib/accesscheck.php" <?php
EDIT "/admin/commonlib/lib/errorlib.php" <?php
EDIT "/admin/commonlib/lib/interfacelib.php" <?php
EDIT "/admin/commonlib/lib/magic_quotes.php" <?php
EDIT "/admin/commonlib/lib/oldphp_vars.php" <?php
EDIT "/admin/commonlib/lib/userlib.php" <?php

EDIT "/admin/commonlib/pages/attributes.php" TO <?php
EDIT "/admin/commonlib/pages/dbcheck.php" TO <?php

EDIT "/admin/commonlib/pages/importcsv.php"
LINE 718 CHANGE <?= TO <?php echo

EDIT "/admin/commonlib/pages/usermgt.php" TO <?php

EDIT "/admin/commonlib/pages/users.php"
LINE 324 CHANGE <?= TO <?php echo
LINE 326 CHANGE <?= TO <?php echo
LINE 327 CHANGE <?= TO <?php echo
LINE 333 CHANGE <?= TO <?php echo

Regards,
Jason
Steps To ReproduceDefault Install of PHPlist
Additional InformationReplace all instances of "<?" with "<?php" and all instances of "<?=" with "<?php echo" in the following files I have found so far:

EDIT "admin/massunconfirm.php" TO <?php

commonlib FOLDER
EDIT "/admin/commonlib/lib/accesscheck.php" <?php
EDIT "/admin/commonlib/lib/errorlib.php" <?php
EDIT "/admin/commonlib/lib/interfacelib.php" <?php
EDIT "/admin/commonlib/lib/magic_quotes.php" <?php
EDIT "/admin/commonlib/lib/oldphp_vars.php" <?php
EDIT "/admin/commonlib/lib/userlib.php" <?php

EDIT "/admin/commonlib/pages/attributes.php" TO <?php
EDIT "/admin/commonlib/pages/dbcheck.php" TO <?php

EDIT "/admin/commonlib/pages/importcsv.php"
LINE 718 CHANGE <?= TO <?php echo

EDIT "/admin/commonlib/pages/usermgt.php" TO <?php

EDIT "/admin/commonlib/pages/users.php"
LINE 324 CHANGE <?= TO <?php echo
LINE 326 CHANGE <?= TO <?php echo
LINE 327 CHANGE <?= TO <?php echo
LINE 333 CHANGE <?= TO <?php echo

 
TagsNo tags attached.

Relationships

related to 0006419 resolveduser1822 Short tags are not supported on everywhere 
related to 0001175 resolvedmichiel Use of short tags 
has duplicate 0012821 resolvedmichiel Script uses PHP short tags 

Activities

Rothgar

21-06-06 06:28

reporter   ~0014634

Related to 0006419.

Rothgar

22-06-06 05:37

reporter   ~0014683

Also edit admin/footer.inc.php and change <?= TO <?php echo

Rothgar

29-06-06 04:01

reporter   ~0014900

Another edit:
admin/commonlib/pages/attributes.php
LINE 297
CHANGE <?= TO <?php echo

user3543

23-04-08 19:00

  ~0045672

Posted: 9:13am, Wed 23 Apr, 2008 by codeway


We recently upgraded to PHP5 and to the latest version of phpList, but the phpList displayed a screenful of PHP scripts instead of the user subscription pages.

The solution was to change "<? " to "<?php " on the first line of magic_quotes.php and userlib.php.

user3543

23-04-08 19:07

  ~0045673

related to:
0008630
0006419
0012821
0001175

h2b2

15-04-10 23:30

manager   ~0050910

I believe this has already been taken care of in one of the previous releases. Marking as resolved in 2.10.11.