View Issue Details

IDProjectCategoryView StatusLast Update
0005159phplist applicationTemplate Managementpublic18-02-08 14:16
Reportericedstitch 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.2 
Target Version2.10.7Fixed in Version2.10.3 
Summary0005159: template images not replaced when re-uploaded
DescriptionWhen updating an image for a template in phplist, I found that the images were not updating, just staying the same as they were before. So I poked around and found that images for template id and image name were not being deleted before the new image was inserted into the table.

Reason being that $$originalname was blank in /admin/class.image.inc on line 139 . So I changed the $$ to $.

Line: 139:
      Sql_Query(sprintf(
            'delete from
                 %s
            where
                 template = %d
            and
                 filename = "%s"
            ',
        $tables["templateimage"],$templateid,$$originalname));

The original images are always saved the first time, further updates do not get updated.
Additional InformationPHP Version 4.3.4.
TagsNo tags attached.

Relationships

related to 0003721 closed phplist 2.10.x 

Activities

There are no notes attached to this issue.