View Issue Details

IDProjectCategoryView StatusLast Update
0004406phplist applicationStatisticspublic18-02-08 14:16
Reportersu 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.1 
Target Version2.10.7Fixed in Version2.10.3 
Summary0004406: Click tracking breaks mixed case URLs
Descriptionhttp://www.hmv.co.uk/hmvweb/displayProductDetails.do?ctx=280;-1;-1;-1&sku=401395

by producing this for the redirect:

http://www.hmv.co.uk/hmvweb/displayproductdetails.do?ctx=280;-1;-1;-1&sku=401395

Why is the text being forced to lowercase? It shouldn't be modified at all.
And is there a quick patch for this? I'm hunting around in files, but only just figured out the issue.
TagsNo tags attached.

Relationships

related to 0003721 closed phplist 2.10.x 
has duplicate 0006001 resolvedmichiel Text Mails changing all HTML links to lowercase 
has duplicate 0006515 resolvedmichiel clicktracking error with uppercase url 
related to 0007162 resolvedmichiel URLs forced to lower case in text emails 

Activities

michiel

14-10-05 19:54

manager   ~0007787

ah, that's a good point, never thought about case in URLs.

in sendemaillib.php

look for (several times)
$link = strtolower(cleanUrl($links[1][$i]));

and take out the strtolower

su

14-10-05 20:11

reporter   ~0007788

Thanks, Michiel. Hopefully, I manged to fix this before the client noticed *grin*

mchristo2

07-04-06 00:11

reporter   ~0012336

I removed the strtolower() from the sendemaillib.php code as instructed, but the hyperlinks placed on text still change to lower case. There are several other uses of strtolower() in sendemaillib.php; should I remove them, too? As in:

if (strtolower(trim($linktext)) == strtolower(trim($linkurl)) ||
      'http://'.strtolower(trim($linktext)) == strtolower(trim($linkurl))) {
        $linkreplace = $linkurl;
    } else {
      $linkreplace = $linktext.' <'.strtolower($linkurl).'>';