View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002809 | phpList 3 application | General | public | 30-03-05 12:12 | 20-05-05 20:14 |
| Reporter | mfischer | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Target Version | Fixed in Version | 2.9.5 | |||
| Summary | 0002809: mysql.inc: Sql_Affected_Rows missing explicit database link | ||||
| Description | The function Sql_Affected_Rows is missing the explicit database connection handler: function Sql_Affected_Rows() { return mysql_affected_rows(); } When e.g. using custom database session save handlers, it's not guaranteed that the last opened mysql link is the one needed by this function. I've seen that Sql_Insert_id() has been fixed since, it would be nice if Sql_Affected_Rows() could be fixed too. | ||||
| Tags | No tags attached. | ||||
|
30-03-05 12:12
|
mysql.inc.diff (312 bytes)
--- mysql.inc-2.9.4 2005-03-30 11:07:33.000000000 +0000
+++ mysql.inc 2005-03-30 11:08:00.000000000 +0000
@@ -166,7 +166,7 @@
}
function Sql_Affected_Rows() {
- return mysql_affected_rows();
+ return mysql_affected_rows($GLOBALS["database_connection"]);
}
function Sql_Num_Rows($result = "") {
|
|
|
Hmm patching file mysql.inc Hunk #1 FAILED at 166. 1 out of 1 hunk FAILED -- saving rejects to file mysql.inc.rej in this case the patch is small enough to do manually, but it would be useful to diff against the CVS code instead |
|
|
I'm sorry I'm unable to do the CVS checkout. This is all I can do for this bug report, this is actually only a one-line change so I hope you're capable of doing it yourself. Thanks. |
|
|
Yes, in this case it's ok, but if you were to submit bigger patches, please use the cvs. |
|
|
Thanks for your accommodation. I promised I will. Cheers. |
|
|
The new line should say: return mysql_affected_rows($GLOBALS["database_connection"]); Figured I'd save everyone the hassle. Damien |
