phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002809phplist applicationAll Otherpublic30-03-05 13:1220-05-05 21:14
Reportermfischer 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version2.9.5 
Summary0002809: mysql.inc: Sql_Affected_Rows missing explicit database link
DescriptionThe function Sql_Affected_Rows is missing the explicit database
connection handler:

function Sql_Affected_Rows() {
   return mysql_affected_rows();
}

When e.g. using custom database session save handlers, it's not
guaranteed that the last opened mysql link is the one needed by this
function.

I've seen that Sql_Insert_id() has been fixed since, it would be nice if
Sql_Affected_Rows() could be fixed too.
TagsNo tags attached.
Attached Filesdiff file icon mysql.inc.diff [^] (312 bytes) 30-03-05 13:12 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0002457resolvedmichiel PHPList v2.9.5 release 

-  Notes
(0004063)
michiel (manager)
30-03-05 14:19

Hmm

patching file mysql.inc
Hunk #1 FAILED at 166.
1 out of 1 hunk FAILED -- saving rejects to file mysql.inc.rej

in this case the patch is small enough to do manually, but it would be useful to diff against the CVS code instead
(0004064)
mfischer (reporter)
30-03-05 14:59

I'm sorry I'm unable to do the CVS checkout. This is all I can do for this bug report, this is actually only a one-line change so I hope you're capable of doing it yourself. Thanks.
(0004065)
michiel (manager)
30-03-05 15:05

Yes, in this case it's ok, but if you were to submit bigger patches, please use the cvs.
(0004066)
mfischer (reporter)
30-03-05 15:14

Thanks for your accommodation. I promised I will. Cheers.
(0004068)
DamienMcKenna (manager)
31-03-05 05:29

The new line should say:

return mysql_affected_rows($GLOBALS["database_connection"]);

Figured I'd save everyone the hassle.

Damien


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker