phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002554phplist applicationConfigurationpublic08-02-05 04:3312-02-09 13:54
ReporterDamienMcKenna 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.9.3 
Target VersionFixed in Version2.9.5 
Summary0002554: commonlib/pages/attributes.php: clean up the UI
DescriptionClean up the UI in a similar fashion to #2553. Replace the per-attribute tables with a single table.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to 0002553closedmichiel admin/spageedit.php: Clean up attributes list 
related to 0003586closed Continuous overall improvement tasks 

-  Notes
(0003430)
DamienMcKenna (manager)
08-02-05 04:52

Change lines 307 onwards to say:

  print "<table border=\"1\" width=\"100%\">\n";
    print " <tr>\n";
    print " <th>tag?</th>\n";
    print " <th>name</th>\n";
    print " <th>used?</th>\n";
    print " <th>type</th>\n";
    print " <th>default</th>\n";
    print " <th>order</th>\n";
    print " <th>required</th>\n";
    print " </tr>\n";

while ($row = Sql_Fetch_array($res)) {

    $c++;
  ?>

    <tr>
        <td><input type="checkbox" name="tag[<?php echo $c; ?>]" value="<?php echo $row["id"]; ?>" /></td>
        <td><input type="text" name="name[<? echo $row["id"]?>]" value="<? echo htmlspecialchars(stripslashes($row["name"])) ?>" size="10" /></td>
        <td><?php
if ($formtable_exists) {
    sql_query("select * from formfield where attribute = ".$row["id"]);
    print Sql_affected_rows();
}
else {
    print '---';
}
 ?></td>
        <td><!--input type=hidden name="type[<?=$row["id"]?>]" value="<?=$row["type"]?>"><?=$row["type"]?>-->
          <select name="type[<?php echo $row["id"]; ?>]" id="type[<?php echo $row["id"]; ?>]" onChange="warn();">
<?
   foreach($types as $key => $val) {
     printf("<option value=\"%s\" %s>%s</option>\n", $val, $val == $row["type"] ? "selected": "", $val);
   }
?>
            </select>
        </td>
        <td><input type=text name="default[<? echo $row["id"]?>]" value="<? echo htmlspecialchars(stripslashes($row["default_value"])) ?>" size="15" /></td>
        <td><input type="text" name="listorder[<? echo $row["id"]?>]" value="<? echo $row["listorder"] ?>" size="3" /></td>
        <td><input type="checkbox" name="required[<? echo $row["id"]?>]" value="1" <? echo $row["required"] ? "checked": "" ?> /></td>
    </tr>

<? } ?>
</table>
(0003431)
DamienMcKenna (manager)
08-02-05 04:55

Waiting to be added to CVS.
(0003573)
michiel (manager)
18-02-05 16:36

marked for 2.9.5


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker