View Issue Details

IDProjectCategoryView StatusLast Update
0002154phpList 3 applicationTemplate Managementpublic20-05-05 20:55
ReporterBruce Morrison 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionnot fixable 
Product Version2.8.11 
Target VersionFixed in Version 
Summary0002154: Unsub screen text
Description"Please select the lists you want to unsubscribe from" displayed even if there is only 1 list & hide_single_list = true.
Additional InformationPatch for 2.8.12 attached
TagsNo tags attached.

Relationships

has duplicate 0002186 resolvedmichiel One list with "Hide Single List" not handled well on unsubscribe 

Activities

10-11-04 01:08

 

unsub.patch (1,661 bytes)
*** index.php.orig	Wed Nov 10 11:56:03 2004
--- index.php	Wed Nov 10 12:22:08 2004
***************
*** 477,490 ****
      return $res;
    }
  
-   $res .= $GLOBALS["strUnsubscribeSelect"].':';
-   $res .= '<ul>';
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
--- 477,490 ----
      return $res;
    }
  
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
+     $res .= $GLOBALS["strUnsubscribeSelect"].':';
+     $res .= '<ul>';
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
***************
*** 506,513 ****
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     $res .= '</ul>
!     <p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
--- 506,514 ----
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     if (!$hide)
!       $res .= '</ul>';
!     $res ='<p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
unsub.patch (1,661 bytes)

10-11-04 01:11

 

unsub.patch (1,661 bytes)
*** index.php.orig	Wed Nov 10 11:56:03 2004
--- index.php	Wed Nov 10 12:22:08 2004
***************
*** 477,490 ****
      return $res;
    }
  
-   $res .= $GLOBALS["strUnsubscribeSelect"].':';
-   $res .= '<ul>';
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
--- 477,490 ----
      return $res;
    }
  
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
+     $res .= $GLOBALS["strUnsubscribeSelect"].':';
+     $res .= '<ul>';
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
***************
*** 506,513 ****
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     $res .= '</ul>
!     <p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
--- 506,514 ----
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     if (!$hide)
!       $res .= '</ul>';
!     $res ='<p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
unsub.patch (1,661 bytes)

Bruce Morrison

10-11-04 01:12

reporter   ~0002560

Last edited: 10-11-04 01:28

Thris patch is the correct one - couldn't delete the other 2 - Access denied

edited on: 10-11-04 01:28

10-11-04 01:27

 

unsub.patch (2,300 bytes)
*** index.php.orig	Wed Nov 10 11:56:03 2004
--- index.php	Wed Nov 10 12:22:08 2004
***************
*** 477,490 ****
      return $res;
    }
  
-   $res .= $GLOBALS["strUnsubscribeSelect"].':';
-   $res .= '<ul>';
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
--- 477,490 ----
      return $res;
    }
  
    $result = Sql_query("SELECT $tables[list].id as id, $tables[list].name as name, $tables[list].description as description FROM $tables[list],$tables[listuser],$tables[user] where $tables[list].id = $tables[listuser].listid and $tables[user].id = $tables[listuser].userid and $tables[user].email = \"$email\"");
    $num = Sql_Affected_Rows();
  	$hidesinglelist = getConfig("hide_single_list");
    $hide =  $num == 1 && $hidesinglelist == "true";
  
    if (!$hide) {
+     $res .= $GLOBALS["strUnsubscribeSelect"].':';
+     $res .= '<ul>';
      $out = ' <li><input type=checkbox name=list[all] value=signoff>'.$GLOBALS["strAllLists"].'
        <li><input type=checkbox name=list[none] value=signoff>'.$GLOBALS["strNoLists"];
    }
***************
*** 506,513 ****
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     $res .= '</ul>
!     <p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
--- 506,514 ----
      $res .= '<p><input type=submit value="'.$GLOBALS["strResubmit"].'">';
    } else {
      $res .= $out;
!     if (!$hide)
!       $res .= '</ul>';
!     $res ='<p><input type=submit name=unsubscribe value="'.$GLOBALS["strUnsubscribeSubmit"].'">';
    }
  
    $res .= '<p>'.$GLOBALS["PoweredBy"].'</p>';
unsub.patch (2,300 bytes)

michiel

11-11-04 15:52

manager   ~0002571

This issue has been dealt with differently in the 2.9 development, so I'll leave this here for anyone to download and use, if they want to address this in the 2.8 versions.

michiel

20-05-05 20:55

manager   ~0004986

unsubscribing has changed in the 2.9 versions so it's not really applicable anymore