View Issue Details

IDProjectCategoryView StatusLast Update
0020183phpList 3 applicationCampaign Send Processpublic29-04-20 14:17
Reporterjimbocity 
PriorityhighSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product Version3.4.8-RC1 
Target Version3.5.0Fixed in Version 
Summary0020183: Statistics link in email is incorrect
DescriptionV3.5.2 (no option to select that in product version above)

In processqueue.php lin 1372:

 s('to view the statistics of this campaign, go to %s://%s', $GLOBALS['admin_scheme'],
                           getConfig('website').$GLOBALS['adminpages'].'/?page=statsoverview&id='.$messageid)
 );

The outputted link prints as: "http://http" .
Perhaps something to do with using the translation tool whilst retaining the %s strings?
TagsNo tags attached.

Activities

michiel

24-04-20 09:08

administrator   ~0063115


What is your config for "website" in the configure page?

When you edit that config, it explicitly says "do not include http://". I think you did include that. But if you didn't, then we can check what's going on.

GLOBALS['admin_scheme'] = 'https'
getConfig('website') = 'yourdomain.com'

That should not create a double http://http

jimbocity

24-04-20 13:53

reporter   ~0063120

The website field in config is "newsletter.fakewebsite.at" (not allowed to give the real domain).
No http or https is included.

michiel

24-04-20 13:54

administrator   ~0063121

ok, that's odd. I'll check if I can replicate that.

michiel

24-04-20 14:22

administrator   ~0063122

I can't replicate that. But it seems you are running in German, so it may be something in the German translation.

jimbocity

27-04-20 14:17

reporter   ~0063124

Yes, I wondered whether the problem is something to do with sending the %s placeholders through the translation function?

duncanc

27-04-20 21:10

updater   ~0063125

The German translation of the message "To view the statistics ..." has only one %s placeholder, for the domain. The "http" part is literal.

jimbocity

28-04-20 08:08

reporter   ~0063126

YES! Well spotted. This is an error in the /admin/locale/de/phplist.po file