View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020112 | phpList 3 application | Interface - Editor | public | 15-11-19 13:53 | 29-04-20 16:14 |
Reporter | duncanc | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Product Version | 3.4.8 | ||||
Target Version | 3.4.9 | Fixed in Version | 3.5.0 | ||
Summary | 0020112: CKeditor menus extend the full width of window with Trevelin theme | ||||
Description | When editing a message or template using the ckeditor plugin the drop-down menu for Styles, Fonts etc extend the full width of the page, see screenshot. This is with the Trevelin theme. When using Dressprow the menus are displayed correctly. This behaviour seems to have always been in Trevelin but no-one raised it as a problem until recently, see https://discuss.phplist.org/t/ckeditor-issues-in-3-4-8/5716 The cause of the wide menu is a css style in phplist-ui-bootlist/css/style.css .cke{width:100% !important} After removing that style the menus are displayed correctly. I guess that the style was added to make the editor fill the window instead of being the default 600px wide, which looks clumsy with Trevelin but looks fine with Dressprow. The issue should have been raised against the ckeditor plugin instead. | ||||
Tags | No tags attached. | ||||
|
|
|
|
|
I have made a change to the ckeditor plugin to work-around this by setting the width to auto. That rule takes priority over that in style.css. The drop-down menus are now displayed correct width, and the editor fits in the available space with both Trevelin and Dressprow. A permanent fix is to either remove the rule and let the plugin control the width, or change the width to auto instead of 100%. |
|
https://github.com/phpList/phplist-ui-bootlist/pull/114 |
|
Shouldn't the less file be changed instead, and the css regenerated? |
|
@duncanc yes, you are right. Thanks for pointing it out. I have reverted the original commit and modified the less file now. |
|
I think this issue can now be closed. |