View Issue Details

IDProjectCategoryView StatusLast Update
0020004phpList 3 applicationGeneralpublic19-07-19 13:45
Reporterduncanc 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.4.3 
Target Version3.4.4Fixed in Version3.4.4 
Summary0020004: php 7.3 PCRE change
DescriptionAfter upgrading a shared hosting to php 7.3. trying to update a plugin failed with

Error: Invalid download URL, please reload the page and try again

When enabling errors this is reported in the error file

[30-Jun-2019 21:15:31 UTC] PHP Warning: preg_match(): Compilation failed: invalid range in character class at offset 26 in /home/dcameron/public_html/lists/admin/plugins.php on line 38

The code line referred to is

    if (!preg_match('~^https?://github\.com/([\w-_]+)/([\w-_]+)/archive/(.+)\.zip$~i', $packageurl, $regs)) {

This appears to be a change to the PCRE package in php 7.3. This construct is interpreted differently to previous php versions
[\w-_]

I think that this is the same as the problem reported at https://bugs.php.net/bug.php?id=77334
TagsNo tags attached.

Activities