View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0019994 | phpList 3 application | Campaign Send Process | public | 20-06-19 08:16 | 19-07-19 13:46 |
| Reporter | petersphilo | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.4.2 | ||||
| Target Version | 3.4.4 | Fixed in Version | 3.4.4 | ||
| Summary | 0019994: 'Select All' checkmark not working when selecting lists for send | ||||
| Description | The problem is in the file: /admin/js/phplistapp.js At line 60, it should be: // Function to check/ uncheck all the boxes in a category. function checkAllBoxes(checked, checkboxes) { checkboxes.each(function () { if (checked) { $(this).find('input[name^=targetlist]').prop('checked', true); } else { $(this).find('input[name^=targetlist]').prop('checked', false); } }); } The attribute was 'id' but should be name And at line 444, here's what i did: // tick all the boxes in a category. $('li.selectallcategory').on('click', function () { if ($(this).find('input[type=checkbox]').attr('name').match('all-lists')) { var ul = $(this).parent(); checkAllBoxes(ul.find('input[name^=all-lists]').prop('checked'), ul); } }); again, attribute was 'id' but should be 'name' also, the call to checkAllBoxes calls the parent of the parent.. that didn't work, at least in Safari, Chrome, and Opera on Mac | ||||
| Tags | No tags attached. | ||||
|
|
phplistapp.js (18,967 bytes) |
|
|
Fix included above |
|
|
@petersphilo Thanks for contributing! |
|
|
@samtuke my pleasure! Sorry it took me so long to get around to it... Quick note: on the 3 PHPList installations i manage, lists are organized in categories, so i can't say whether this issue exists if you have no categories... Also, this issue has been around for a very, very long time (at least since 3.1.x).. i'm surprised that i've not found mention of it in Mantis.. Thank you all for PHPList!! it really rocks! |
|
|
@petersphilo Checking all boxes using id attribute affects 'match('all-lists') ' property as undefined. It works well with name attribute as it is declared in \admin\connect.php file: // Add select all checkbox in every category to select all lists in that category. if ($category == 'selected') { $content = sprintf('<li class="selectallcategory"><input type="checkbox" name="all-lists-'.$fieldname.'-cat-'.str_replace(' ', '-', strtolower($category)).'" checked="checked">'.s('Select all').'').$content; } Thanks for contributing! You wrote: also, the call to checkAllBoxes calls the parent of the parent.. that didn't work, at least in Safari, Chrome, and Opera on Mac. checkAllBoxes function works ok calling lists by name and not id. Let us know if you have any other questions. PR on GitHub: https://github.com/phpList/phplist3/pull/560 |
