View Issue Details

IDProjectCategoryView StatusLast Update
0019307phpList 3 applicationInterface - Frontendpublic11-10-18 13:11
Reporterfsrs 
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.3.3 
Target Version3.3.5Fixed in Version 
Summary0019307: php code in page templates appearing the html href="admin/ui/phplist-ui-bootlist/css/style.css?v=<?php echo filemtime(dirname(_
DescriptionFresh installation.
The Subscribe page template includes php code which can never run.


Steps To Reproduce1) Install phplist
2) goto Config -> Subscribe Pages -> Add A New Subscribe Page
3) go to the "Header" field
4) the fifth line is <link rel="stylesheet" href="admin/ui/phplist-ui-bootlist/css/style.css?v=<?php echo filemtime(dirname(__FILE__).'/css/style.css'); ?>" />

this never actually executes, so the php just gets passed through to the client browser.
Additional InformationThe intent of the code is to force client browsers to load modified css immediately, however this is never going to work in a static header template stored in the DB

If the loading of CSS immediately on modification is required the stylesheet reference will have to be generated at runtime.
TagsNo tags attached.

Activities

fsrs

29-06-18 14:47

reporter  

phplist-codeinhtml.png (201,942 bytes)
phplist-codeinhtml.png (201,942 bytes)

user5081

21-07-18 21:01

  ~0060929

Thanks. @fsrs
PR: https://github.com/phpList/phplist-ui-bootlist/pull/62