View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0019257 | phpList 3 application | Internationalization (l18n) | public | 27-05-18 09:44 | 13-02-19 12:38 |
| Reporter | Dragonrider5 | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.3.0 | ||||
| Target Version | 3.3.4 | Fixed in Version | 3.3.3 | ||
| Summary | 0019257: Contact Administrator not translatable | ||||
| Description | It's been reported in the forums that in 3.3.3 that the new string displayed on the subscribe to our lists page for "Contact the Administrator" is not translated and is in fact hard coded in the lists/index.php file. (Line 375) https://discuss.phplist.org/t/new-string-contact-the-administrator-in-3-3-3/4018 | ||||
| Steps To Reproduce | just visit subscribe page | ||||
| Additional Information | I've added the string $strContactAdmin = "Contact the Administrator"; to lists/texts/english.ini and changed s(‘Contact the administrator’) to: $GLOBALS[‘strContactAdmin’] in lists/index.php This seems to solve the reported issue, perhaps for consideration for the next update? | ||||
| Tags | No tags attached. | ||||
|
|
@Dragonrider5 thanks for reporting this. It appears that the string is in fact translatable (the s() function is equivalent to using $GLOBALS['']). But the string is not listed on Pootle (translate.phplst.org). It may be that the automatic translation process isn't working. We shall investigate. |
|
|
It's not quite the case that s() and $GLOBALS[''] are equivalent because they can be using different languages. s() will use the language of the current administrator, defaulting to $default_system_language, so hasn't really been designed for use on the public pages where there is no current admin. The public pages have their own default language through $language_module. The strings on the /lists page will be translated using that. So if that is german.inc then the preferences text $strPreferencesTitle is displayed as Einstellungen ändern regardless of the default admin language. I guess that the default admin language and default public page language will often be the same, but someone might want the admin pages to be in English and have public pages in the local language. It might be best to continue using the $GLOBALS approach, although I have no idea how new strings get translated. |
|
|
@duncanc Great point, thanks. I wasn't aware of that. |
|
|
Potentially related: in the forum it has been reported that this string is also not translating properly: $strPersonalLocationSent Original report: https://discuss.phplist.org/t/two-bugs-in-the-automated-translation-from-english-to-german/4072 |
|
|
PRs: https://github.com/phpList/phplist3/pull/339 & https://github.com/phpList/phplist-lan-texts/pull/18 |
