0019045: Fix miscalculation of percentages on Campaign statistics page

ID	Project	Category	View Status	Date Submitted	Last Update

0019045	phpList 3 application	Interface - Administrator	public	16-01-18 19:10	28-03-18 12:21

Reporter	samtuke	Assigned To
Priority	urgent	Severity	minor	Reproducibility	have not tried
Status	resolved	Resolution	fixed
Platform	Linux	OS	Fedora	OS Version	26
Product Version	3.3.1
Target Version	3.3.2	Fixed in Version	3.3.2

Summary	0019045: Fix miscalculation of percentages on Campaign statistics page
Description	Currently the Statistics overview page (e.g. /lists/admin/?page=statsoverview&id=2) has incorrect percentage statistics such as: Opened -1550.27 % Clicked -2884.73 % Click Ratio 186.08 % Fix the erroneous calculation to give the literal statistics, as well as the percentages. E.g.: Opened 10 (10%) Clicked 5 (5%) Click Ratio 50%
Tags	quick-fix

samtuke 16-01-18 19:12 administrator ~0059846	The dummy database contains sufficient data to illustrate this issue, and is used in the attached screenshot (https://resources.phplist.com/develop/infrastructure#code). Tested with real data from a production installation server also. Selection_381.png (94,766 bytes) Selection_381.png (94,766 bytes)

duncanc 21-01-18 10:28 updater ~0059866	Probably caused by an error in an earlier pull request https://github.com/phpList/phplist3/pull/149/files number_format() should not be applied to $totalSent Also, there are two rows which are erroneously not displayed - the opened total and the clicked total. See my comment https://github.com/phpList/phplist3/pull/236#issuecomment-355768164

samtuke 22-01-18 12:40 administrator ~0059880	@duncanc Good call -- @xheni Duncan's comments should help with resolving this issue, and the related one he describes.

xheni 22-01-18 15:20 administrator ~0059884	@duncanc thanks for your comments. PR : https://github.com/phpList/phplist3/pull/244