View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0018945 | phpList 3 application | Internationalization (l18n) | public | 11-11-17 23:53 | 19-11-19 22:33 |
Reporter | Assigned To | ||||
Priority | normal | Severity | minor | Reproducibility | always |
Status | new | Resolution | open | ||
Platform | Linux | OS | Ubuntu | OS Version | 16.04 |
Target Version | next major | ||||
Summary | 0018945: Missing page_title in pot template for page userclicks | ||||
Description | on /?page=userclicks there are no translation. I checked the pot file pagetitles in template directory in /locale and there none pagetitle:userclicks so i think this is an error in translation system. But I don't know how to add pagetitle:userclicks to that pot file. | ||||
Tags | No tags attached. | ||||
|
To clarify, the page title has been manually set as Marie is unclear how to use /locales/language/pagetitles.php to set the page title automatically. |
|
The change in phplist-ui-bootlist/functions.php doesn't seem to do what you intended if ($page_title =='userclicks') $page_title = s('Click Statistics'); /* REMOVE AFTER RESOLVE MANTIS #18945 */ $page_title has not been defined when functions.php is included so there is a php notice issued [Sat Jun 09 17:14:42.583296 2018] [:error] [pid 10643] [client 127.0.0.1:52434] PHP Notice: Undefined variable: page_title in /home/duncan/www/lists_3.3.3/admin/ui/phplist-ui-bootlist/functions.php on line 2, referer: http://strontian/lists/admin/?page=eventlog&tk=df0407859e24d56f91e13fb0b5a22153 and the page title remains "userclicks". |
|
|
|
If I remove that line in functions.php, the page title in the content change to "userclicks" too. Anyway, it will be great to do this properly, and add the page_title of this page same way the others pages are, but I don't know how to do it. Can you help me? |
|
We need to add a hook in the main system to call a function in the theme to set it. I'm not so happy about this "functions.php" thing that was pushed into the process, and I'd like to rethink this to make it a proper integration, eg with a plugin, or with plugin like calls. For now, it's working, so there's no rush to fix that. It's not "nice", but we can live with it. |