View Issue Details

IDProjectCategoryView StatusLast Update
0018945phpList 3 applicationInternationalization (l18n)public19-03-19 15:28
Reporteruser5081 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformLinuxOSUbuntuOS Version16.04
Product Version 
Target Versionnext majorFixed in Version 
Summary0018945: Missing page_title in pot template for page userclicks
Descriptionon /?page=userclicks there are no translation. I checked the pot file pagetitles in template directory in /locale and there none pagetitle:userclicks so i think this is an error in translation system. But I don't know how to add pagetitle:userclicks to that pot file.
TagsNo tags attached.

Activities

samtuke

13-11-17 15:17

administrator   ~0059665

To clarify, the page title has been manually set as Marie is unclear how to use /locales/language/pagetitles.php to set the page title automatically.

duncanc

09-06-18 17:30

updater   ~0060706

The change in phplist-ui-bootlist/functions.php doesn't seem to do what you intended

if ($page_title =='userclicks') $page_title = s('Click Statistics'); /* REMOVE AFTER RESOLVE MANTIS #18945 */

$page_title has not been defined when functions.php is included so there is a php notice issued

[Sat Jun 09 17:14:42.583296 2018] [:error] [pid 10643] [client 127.0.0.1:52434] PHP Notice: Undefined variable: page_title in /home/duncan/www/lists_3.3.3/admin/ui/phplist-ui-bootlist/functions.php on line 2, referer: http://strontian/lists/admin/?page=eventlog&tk=df0407859e24d56f91e13fb0b5a22153

and the page title remains "userclicks".

duncanc

09-06-18 17:33

updater  

user5081

10-06-18 23:58

  ~0060708

If I remove that line in functions.php, the page title in the content change to "userclicks" too.
Anyway, it will be great to do this properly, and add the page_title of this page same way the others pages are, but I don't know how to do it. Can you help me?

michiel

11-06-18 20:09

manager   ~0060711

We need to add a hook in the main system to call a function in the theme to set it. I'm not so happy about this "functions.php" thing that was pushed into the process, and I'd like to rethink this to make it a proper integration, eg with a plugin, or with plugin like calls.

For now, it's working, so there's no rush to fix that. It's not "nice", but we can live with it.