View Issue Details

IDProjectCategoryView StatusLast Update
0018449phplist applicationTheme - Trevelinpublic29-01-17 12:02
Reporterduncanc 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.2.6 
Target VersionFixed in Version3.3.0 
Summary0018449: Packaging the theme
DescriptionThis is suggestion for when the theme is packaged to be included within phplist.

Only the files needed at run-time should be included in order to reduce the size.
So the bootstrap directory and I think the less directory can be excluded, along with individual files such as license and readme.
TagsNo tags attached.

Activities

duncanc

27-01-17 17:48

developer   ~0058683

Just looked at phplist 3.3.0 RC4 and that includes the complete phplist-ui-bootlist github repository, which comes to 11MB. The bootstrap subdirectory takes 10.9MB of that of which the docs subdirectory takes 8.4MB.

From what I can see bootstrap has a "dist" subdirectory that seems to contain all that is needed in css, fonts and js subdirectories, which comes to 1.1MB. All the rest of the bootstrap directory is probably not needed by phplist.

I suggest either having a "build" process that generates only the files required by phplist, or maybe using .gitignore depending on exactly how the bootlist repository is meant to be included in the phplist repository.

michiel

27-01-17 22:20

manager   ~0058686

Yes, good point, I will do that.

michiel

27-01-17 23:14

manager   ~0058687

actually, do we need the bootstrap folder at all?

It would be best if all CSS we need is just in the css folder.

Mariela, of these folders in the bootlist theme, which ones are needed:

- bootstrap
- fonts
- js
- less
- pages
- css

Can we do with just "css", "js" and "pages"?

mariez

28-01-17 18:38

developer   ~0058691

AND "FONTS".

/css, /js, /pages and /fonts are needed for this theme to work.
/bootstrap and /less are needed only for development.