|
|
Any idea which ones? Seems related to 0018295 |
|
|
Two pages, uclicks.php and userclicks.php have queries using GROUP BY that need changing (including the related issue). I've been looking at those today and should be able to make a pull request tomorrow. |
|
|
brilliant, that sounds great. Looking forward to the PR. |
|
|
Screenshot from 2016-09-16 18-24-32.png (14,384 bytes) |
|
|
Screenshot from 2016-09-16 18-35-44.png (18,950 bytes) |
|
|
See https://github.com/phpList/phplist3/pull/85 There is an outstanding problem with the user clicks page 'Clicks of a subscriber'. The query for that now fails because it uses a non-aggregated field, message id. This highlights a problem with the current code using the non-strict group by. A url can be used in more than one message. The results listing has a message column but, as a url can be used in more than one message, mysql will have returned an arbitrary message id value when there the url has been used in several messages. |
|
|
PR ready for merging |
|
|
PR Merged. But sounds like it's not all resolved yet? It needs a fix on the user clicks page as well. |
|
|
If you go to this page in your phplist with a user id - admin/?page=userclicks&userid=9999 to see what I mean. The totals are correct but the Message column in the results is misleading. When a url has been used in only one message then it is correct, but otherwise it is just an arbitrary value from the several possible values selected by mysql. |
|
|
What do you want to do about the Message column on the User Clicks page? Leave it as it is? |
|
|
I guess best would be if it's a list of messageIDs, but that may be tricky to squeeze in a single SQL query. Maybe drop the column for now. |
|
|
See PR https://github.com/phpList/phplist3/pull/86 It lists all of the message ids, with each a link to the message. |
|
|
nice one! |
- Anonymous
