View Issue Details

IDProjectCategoryView StatusLast Update
0018198phplist applicationMessage Send Processpublic29-09-16 15:40
Reporterduncanc 
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version3.2.6 
Target Version3.2.6Fixed in Version3.2.6 
Summary0018198: Trying to copy a message for repeat processing fails when STRICT_TRANS_TABLES is enabled
DescriptionThis is related to other problems when mysql has STRICT_TRANS_TABLES enabled, https://mantis.phplist.org/view.php?id=17148

In this case it is not triggered by a user input field but by an sql query

    Sql_Query(sprintf('update %s set embargo = "%s",status = "submitted",sent = "" where id = %d',
        $GLOBALS['tables']['message'], $msgdata['newembargo'], $newid));

see file connect.php line 1836.

The sent column is a datetime so trying to assign an empty string triggers an error

phpList - Database error 1292 while doing query Incorrect datetime value: '' for column 'sent' at row 1
phpList - Sql error update phplist_message set embargo = "2016-07-08 11:00:00",status = "submitted",sent = "" where id = 259

As the column is nullable it should be set to null instead.

The effect of this is to repeat the original message but with the same embargo, which causes the new message to be sent immediately instead of in the future.
TagsNo tags attached.

Activities

duncanc

24-07-16 12:13

developer   ~0058030

See pull request https://github.com/phpList/phplist3/pull/80

gingerling

21-09-16 16:23

manager   ~0058276

Can I just check the product version here Duncan, was is 3.2.5? Do you know how long this bug has been here for? It seems like a big bug if it was affecting all repeating campaigns? (this is for the release notes)

gingerling

29-09-16 15:40

manager   ~0058306

Hi duncan, need some more info for release notes - especially if this has been effecting all repeating campaigns (sound serious) and if you know how long for