View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0018011||phpList 3 application||Interface - Frontend||public||11-02-16 20:31||15-01-18 19:25|
|Target Version||3.3.2||Fixed in Version||3.3.2|
|Summary||0018011: Change "Messages" to "Message" in user history table|
|Description||On page /lists/admin/?page=userhistory, the table has a heading "Messages", under which each row states a single message ID. Replacing this with "Message" would make the label clearer, as each row relates to a single message, rather than each row relating to multiple messages.|
This issue applies to all uses of, I think, a WebblerListing object. The title of the WebblerListing is used as the heading of the left-most column, as well as the title of a wrapping UI panel.
See the Campaigns page for another example. Using a singular word for the panel's title would look more odd than having a plural for a column's title.
The "change" is a bit bigger than a wording change. I think it is to allow a WebblerListing to have an extra column title, then review and change everywhere that that is used.
I think it should also use "Campaign" instead of "Message".
We can fairly easily add a method to change the label to the WebblerListing object and make it fall back to the existing text if not set. Then call this method in this place.
I think it can do with an update in many other places.
It looks like we need a second field so that a webbler listing has a title (used in the panel) and also a heading for the left-most column.
What is your preference for the current title field,
should it be used for the panel and have a new field for the column,
or should it be used for the column heading and have a new field for the panel?
||See pull request https://github.com/phpList/phplist3/pull/55|
||PR merged. Does that solve this issue though?|
||Yes it should solve the issue described in the initial report, but other labels like "campaign" have not been updated. They can be easily however using the newly added method.|
||Another PR relating to a fix of this issue: https://github.com/phpList/phplist3/pull/235|