phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0018011phplist applicationInterface - Frontendpublic11-02-16 20:3119-07-17 15:59
Reportersamtuke 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusnewResolutionopen 
PlatformOSOS Version
Product Version3.2.4 
Target Version3.3.3Fixed in Version 
Summary0018011: Change "Messages" to "Message" in user history table
DescriptionOn page /lists/admin/?page=userhistory, the table has a heading "Messages", under which each row states a single message ID. Replacing this with "Message" would make the label clearer, as each row relates to a single message, rather than each row relating to multiple messages.
Tagsquick-fix
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0057506)
duncanc (developer)
12-02-16 07:43

This issue applies to all uses of, I think, a WebblerListing object. The title of the WebblerListing is used as the heading of the left-most column, as well as the title of a wrapping UI panel.

See the Campaigns page for another example. Using a singular word for the panel's title would look more odd than having a plural for a column's title.

The "change" is a bit bigger than a wording change. I think it is to allow a WebblerListing to have an extra column title, then review and change everywhere that that is used.
(0057507)
michiel (manager)
12-02-16 12:19

I think it should also use "Campaign" instead of "Message".

We can fairly easily add a method to change the label to the WebblerListing object and make it fall back to the existing text if not set. Then call this method in this place.

I think it can do with an update in many other places.
(0057605)
duncanc (developer)
16-04-16 10:36

It looks like we need a second field so that a webbler listing has a title (used in the panel) and also a heading for the left-most column.

What is your preference for the current title field,
should it be used for the panel and have a new field for the column,
or should it be used for the column heading and have a new field for the panel?
(0057613)
duncanc (developer)
17-04-16 17:58

See pull request https://github.com/phpList/phplist3/pull/55 [^]
(0057657)
michiel (manager)
20-04-16 19:58

PR merged. Does that solve this issue though?
(0057659)
samtuke (administrator)
21-04-16 10:28

Yes it should solve the issue described in the initial report, but other labels like "campaign" have not been updated. They can be easily however using the newly added method.


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker