View Issue Details

IDProjectCategoryView StatusLast Update
0017649phpList 3 applicationStatisticspublic11-10-18 15:20
Reporterduncanc 
PrioritynormalSeverityminorReproducibilitysometimes
Status assignedResolutionopen 
Product Version3.0.12 
Target Versionnext patchFixed in Version 
Summary0017649: Click tracking decoding urlencoded characters
DescriptionA problem with click tracking urldecoding a url, see https://forums.phplist.com/viewtopic.php?f=35&t=42323

A literal & had been encoded as %26 but that had been decoded for the url stored in the linktrack_forward table.

As this seems such a basic problem I searched for a similar bug report but surprisingly could not find one. Maybe I am misunderstanding things but I don't understand why a url in a message needs to be urldecoded (which is done in the function parseQueryString() in lib.php).
TagsNo tags attached.

Relationships

related to 0017596 assignedmichiel Links containig a uid are changed to something different 
related to 0017638 new special characters in links converted and breaking links 

Activities

michiel

21-04-15 10:06

manager   ~0056026

looking back in the logs, originally it used "parse_str", but that turned full stops into underscores, so that eg "param=1.2.3.4" was replaced with param=1_2_3_4

so, to avoid that, the parseQueryString was created. This is, in order to be able to remove certain parameters from the URL, eg PHPSESSID and uid.

In fact, this caused another issue, which is the uid one.

duncanc

16-02-18 07:34

developer   ~0060012

This problem has been reported again in the user forum https://discuss.phplist.org/t/double-equal-removed-by-phplsit/3669/5

Any chance of this being addressed, or at least a discussion of what the solution might be?

samtuke

16-02-18 15:45

administrator   ~0060015

@duncanc Thanks for raising this again; strange that it has not been reported more often. I have not noticed it in my own campaigns. Assigned.

duncanc

21-09-18 09:55

developer   ~0061147

A quick fix https://github.com/phpList/phplist3/pull/407 but the whole area could do with reworking and simplifying.