phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0017210phplist applicationInterface - Administratorpublic04-06-14 12:3311-06-14 09:16
Reporterwtps0n 
PrioritynormalSeveritytrivialReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.0.6 
Target Version3.0.7Fixed in Version3.0.7 
Summary0017210: There is question marks instead of polish/hungarian special chars
DescriptionWhen working with polish translation, admininstrator interface shows question marks where should polish UTF-8 encoded letters. I've also checked this out and there is similiar problem with hungarian translation. Problem is with using strtolower php function. There should be mb_strtolower used. I've made a three small patches which resolves this issue.
Steps To ReproduceInstall fresh phplist, use UTF-8 in php.ini or apache configuration (php_value default_charset "utf-8"). After that go to administration panel and change language to polish (polski). You will see :-))
TagsNo tags attached.
Attached Filespatch file icon index.php.patch [^] (627 bytes) 04-06-14 12:33 [Show Content]
patch file icon connect.php.patch [^] (1,073 bytes) 04-06-14 12:33 [Show Content]
patch file icon commonlib_lib_interfacelib.php.patch [^] (3,086 bytes) 04-06-14 12:34 [Show Content]
png file icon polish.png [^] (35,037 bytes) 04-06-14 17:43


png file icon phplist-pl.png [^] (32,682 bytes) 05-06-14 17:29

- Relationships

-  Notes
(0053866)
michiel (manager)
04-06-14 17:44


I cannot replicate that on my system. Although there does seem to be something weird with the translations all being "update translation".

But the UTF8 encoding is fine. Could it be caused by something else?
(0053870)
wtps0n (reporter)
04-06-14 21:23

Ok, I think what could be a problem that is not replicated on your system. Could you check http://pl1.php.net/manual/en/mbstring.overload.php [^] in your php.ini? On my system there is: mbstring.func_overload = 0

But I think better solution is to apply my patches - on some systems it could not be able to set above variable mbstring.func_overload. What do you think?
(0053871)
michiel (manager)
04-06-14 21:30

php -i |grep overload

mbstring.func_overload => 0 => 0
xdebug.overload_var_dump => On => On

Can you give me a screenshot of the error?

Any chance to provide the patches as Merge Requests on Github?
(0053876)
wtps0n (reporter)
05-06-14 17:32

Screenshot uploaded.

And how to apply patches? Sorry, but I can not understand your question...
(0053878)
michiel (manager)
05-06-14 22:11

ok, will try to look into it.

Github is here: https://github.com/michield/phplist [^]

The way it works is to clone the code and then push the changes as "Merge Requests"
(0053886)
wtps0n (reporter)
09-06-14 13:37

OK, I've sepnt some time to merge changes, but I failed :-((( Maybe because I'm not familiar with git - I'm not using it. Do you have any quick step-by-step instructions?
(0053888)
gingerling (administrator)
09-06-14 15:06

I can help write this - M if you can do a very basic guide I will elaborate and perhaps wtps0n could take screenshots for us? Would be a good little blog article :)
(0053901)
michiel (manager)
10-06-14 12:31

well, to contribute via github, you need to do the following (off the top of my head)

1. register with github
2. Fork the phpList code: https://github.com/michield/phplist [^] (and click fork at the top right).
3. Clone your repository to your machine.
(on Linux type "git clone https://github.com/ [^][your github acct]/phplist.git")

You do the above once, and then you're set up to work on it.

Use the docs to set yourself up to run phpList from the code you just checked out

Then you use the git workflow to push changes to your own repository:

https://help.github.com/categories/54/articles [^]
https://help.github.com/categories/19/articles [^]

And when you have a change that you think will improve the way phpList works, you create a Merge Request on Github. That will automatically create an issue in the issue tracker.

It may be useful to set up a sandbox for this,
(0053902)
wtps0n (reporter)
10-06-14 13:34

Thanks a lot for your quick setup. I've made a new issue, and hope that it will be added to master repository.
(0053915)
michiel (manager)
11-06-14 09:16

https://github.com/michield/phplist/pull/27 [^]


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker