View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0017020||phpList 3 application||Interface - Administrator||public||19-01-14 09:34||21-10-14 14:51|
|Target Version||3.0.6||Fixed in Version||3.0.4|
|Summary||0017020: text in menu is converted to all-lower-case which is an error in quite a few languages other than english|
|Description||I try (hard) to use phpList 3.0.5 in German.|
One obstacle in the admin interface is the nice menu:
the menu changes the spelling of strings that are initially translated correctly:
e.g. pagetitles.php correctly says: "Statistik: Klicks pro Nachricht"
but in the menu it is rendered as "Statistik: klicks pro nachricht"
which is downright wrong.
Please do not change, transform or tweak the strings that come out of the language packs.
|Steps To Reproduce||open $site/lists/admin.|
in the language chooser, pick "Deutsch"
Hover the mouse over the "Statistics" menu
read the menu items
|Tags||No tags attached.|
I thought that had been dealt with already. It has come up before.
but it can do with a review, just to make sure
The "title" into the href is "Statistik: Klicks pro Nachricht", but the text is "Statistik: klicks pro nachricht.
I don't see any "lowercase" into the css to change this. If there is no "strtolower" in the php, i think this is the original string for that text.
this one looks suspicious:
$linktext = ucfirst(strtolower($desc));
$linktext = str_ireplace('phplist','phpList',$linktext);
I changed that to
$linktext = $desc;
et voilá, looks much better
|That looks suspicious to me too. Michiel, this not seem to be a design issue, but i can do this change in the repository if you want.|
great you found it. Will update the code before rolling out the next version.
Thanks for all the input !
|Change commited for next version.|