View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016914 | phpList 3 application | Internationalization (l18n) | public | 12-10-13 22:24 | 13-02-19 12:38 |
Reporter | rampardes | Assigned To | |||
Priority | normal | Severity | feature | Reproducibility | always |
Status | new | Resolution | open | ||
Product Version | 3.0.5 | ||||
Target Version | next patch | ||||
Summary | 0016914: add support for RTL languages | ||||
Description | phplist.css includes tag: html, body {text-align:left; .... needless to say it does not fit RTL languages - which demends "text-align:right" also, I've added "<html dir="rtl" lang="he">" to the index.php - which I found to be very helpful correcting wrong direction issues. I suggest to add those 2 corrections in order to display Hebrew and Arabic. | ||||
Tags | No tags attached. | ||||
|
could you add a list of changes required for this to work? If you can do this with github pull requests, that would even be better. |
|
public_html/lists/index.php @@ -1,3 +1,4 @@ +<html dir="rtl" lang="he"> <?php ob_start(); public_html/lists/admin/sendemaillib.php @@ -683,7 +683,7 @@ function sendEmail ($messageid,$email,$hash,$htmlpref = 0,$rssitems = array(),$f # check that the HTML message as proper <head> </head> and <body> </body> tags # some readers fail when it doesn't if (!preg_match("#<body.*</body>#ims",$htmlmessage)) { - $htmlmessage = '<body>'.$htmlmessage.'</body>'; + $htmlmessage = '<body dir="rtl">'.$htmlmessage.'</body>'; } if (!preg_match("#<head.*</head>#ims",$htmlmessage)) { if (!$adddefaultstyle) { public_html/lists/styles/phplist.css @@ -102,11 +102,11 @@ Clearing Layout ----------*/ -html, body {text-align:left; background:#f7f6f7 url("../images/page_bk.png") top left repeat-x} +html, body {text-align:right; background:#f7f6f7 url("../images/page_bk.png") top left repeat-x} body.fixed {text-align:center; background: #FFF url("../images/page_bk_nomenu.png") top left repeat-x} #container {margin: 0 20px; min-width: 920px} -.fixed #container {width: 920px; text-align:left; margin: 0 auto} +.fixed #container {width: 920px; text-align:right; margin: 0 auto} #header {height: 106px; width: 100%} |
|
adding the github references: https://github.com/michield/phplist/pull/7 https://github.com/michield/phplist/pull/8 https://github.com/michield/phplist/pull/9 7 is for the frontend HTML 8 is for an HTML message 9 is for the backend HTML so, interestingly enough all three have a different context and will need independent solutions. |
|
can you do an upgrade from git and the dressprow UI svn repo and see if it's ok when you change to hebrew? Also, I found the cause for hebrew not updating (I think). You are running the git version and it didn't have hebrew yet. |
|
I've now also updated it for the frontend. If you update all (including the texts folder and the dressprow) and set a subscribe page to use hebrew.inc it should display RTL. |
|
|