0016869: Multiple records written to the event log

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1

View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0016869

phplist application

Message Send Process

public

06-09-13 23:34

09-09-13 14:53

Reporter

duncanc

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

3.0.3

Target Version

3.0.X

Fixed in Version

3.0.4

Summary

0016869: Multiple records written to the event log

Description

When a message fails when sending to an email address three records are written to the event log each with the same information.

in class phplistmailer the method compatSent()writes a record to the event log,
then when it returns to function sendemail() in sendemaillib.php that function then calls output() which also writes to the event log, and then explicitly writes to the event log.

In that order these are the records in the event log:

Error sending email to Error sending email to aa31528@huskies.bloomu.edu

Error sending message 5 (6/19) to aa31528@huskies.bloomu.edu (aa31528@huskies.bloomu.edu)

Error sending message 5 to aa31528@huskies.bloomu.edu (aa31528@huskies.bloomu.edu)

One of these is sufficient.

I suggest removing the event logging from compatSent(), as the calling function can itself decide what to do. Then either call output() with the second parameter set to false so that it does not log, or remove the explicit call of logEvent().

Notes
(0052254) michiel (manager) 07-09-13 00:30	yes, seems overkill indeed :-)

Relationships [ Relation Graph ] [ Dependency Graph ]