View Issue Details

IDProjectCategoryView StatusLast Update
0016854phplist applicationPlugin APIpublic15-10-14 17:07
Reporterduncanc 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.0.2 
Target Version3.0.XFixed in Version3.0.9 
Summary0016854: Explanation for plugin method sendMessageTabSave() is misleading
DescriptionIn file defaultplugin.php the documentation comment for method sendMessageTabSave() is incorrect

    ## add a tab to the "Send a Message page" for options to be set in the plugin
    # parameters:
    # messageid = ID of the message being saved (should always be > 0)
    # messagedata = associative array of all data from the db for this message
    # returns: HTML code to communicate the result to the user

In file send_core.php, the comment before calling the plugins looks to be more correct, although the method does not allow the plugin to return modified data.
The return value $resultMsg is overwritten by each plugin and then is not used elsewhere.

  ### allow plugins manipulate data or save it somewhere else

TagsNo tags attached.

Activities

michiel

29-08-13 12:25

manager   ~0052230

Hmm, yes, that is from before the core saves all data in the send-message page.

I'll review.

michiel

19-07-14 14:49

manager   ~0054330


do you know of any plugins using this? Maybe it should just go.

michiel

15-10-14 17:07

manager   ~0055428

updated a little