View Issue Details

IDProjectCategoryView StatusLast Update
0016798phpList 3 applicationSubscriber Importpublic21-06-18 14:00
Reporterdymitar Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
Status newResolutionopen 
Product Version2.11.10 
Summary0016798: Extend the "invalid" check not only for empty, but for invalid emails
DescriptionI would like to propose that you extend the validity check for really invalid emails as well.
Importing subscribers with invalid emails leads to future problems.

Additional InformationThis can be done by changing the validation from:
--------------------
    ## Check completeness
    $index = clean($system_values["email"]);
    $invalid = 0;
    if ((!$index) {....
--------------------
to:
--------------------
    ## Check completeness
    $index = clean($system_values["email"]);
    $isEmail = is_email($system_values["email"]); //DD
    $invalid = 0;
    if ((!$index) || (!$isEmail)) {....
-----------

in the corresponding files
Tagsdocumentation, Subscriber Management and data accessibility

Activities

michiel

31-05-13 18:44

administrator   ~0052073


yes, probably a good idea.

michiel

08-07-15 13:27

administrator   ~0056370


Hmm, even though I agree it's a good change, I'm not sure to do this. The reason is that there are use-cases where not validating the email address can come in handy.

For example, if you have an in-house Database, but you do not know the email address for everyone. You can then keep the two DBs in sync with the foreignkey and not require a valid email. Sure, you can't send newsletters, but you have a clear mapping from in-house DB to phpList DB.