View Issue Details

IDProjectCategoryView StatusLast Update
0016786phplist applicationSystem Adminpublic07-05-13 22:41
Reporterduncanc 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.11.9 
Target Version2.11.10Fixed in Version2.11.10 
Summary0016786: Changing the lists to which a subscriber belongs does not set the 'entered' datetime on listuser table
DescriptionThis problem exists in 2.10.19 and is in 2.11.9.

When adding a user or amending a user through the admin user page, the 'entered' field on the listuser table is not set. The table schema allows it to be null, but for consistency with a user subscribing directly, when the field is set, the field should be set to the current time.

See line 211 of file admin/commonlib/pages/user.php:

         Sql_Query("insert into {$tables["listuser"]} (userid,listid) values($id,$lst)");

It can be changed to:

         Sql_Query("insert into {$tables["listuser"]} (userid,listid,entered) values($id,$lst,now())");
TagsNo tags attached.

Activities

michiel

06-05-13 15:25

manager   ~0052033


hmm, I wouldn't want the admin editing a subscriber to change the date at which they signed up to the list. So, it is valid to do this, but only if the entry is empty.

Also, the modified should (and can always) be changed.

duncanc

06-05-13 19:22

developer   ~0052034

On closer look the problem appears to be that the processing deletes all existing list memberships and then adds those that are selected. So it loses the original entered value.

michiel

06-05-13 22:31

manager   ~0052035

ah, so that's wrong to start with. Will try to look at it and improve

michiel

07-05-13 22:41

manager   ~0052036

rev 3819