phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0016761phplist applicationPlugin APIpublic22-03-13 15:2427-03-13 12:02
Reporterduncanc 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product VersionSVN 
Target Version2.11.8Fixed in Version2.11.8 
Summary0016761: Remove use of eval()
DescriptionUsing SVN trunk

In file pluginlib.php line 59
        eval("\$pluginInstance = new ". $className ."();");

The eval is unnecessary as php allows a variable class name, and can be replaced by:
        $pluginInstance = new $className();
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0051989)
michiel (manager)
26-03-13 14:48

I think there was a reason I did it like that, but I can't remember. :-)
(0051993)
duncanc (developer)
27-03-13 09:40

Possibly to trap an error when creating the plugin object, but I don't think that eval will do that.
(0051995)
michiel (manager)
27-03-13 12:02

yes, seems to work all fine without the eval.


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker