0016706: EMBEDUPLOADIMAGES functionality

(0051814)
michiel (manager)
31-10-12 11:22

are you sending your queue with commandline or in-browser?

presumably commandline. For commandline, it needs to save the "Image Path" in the DB, because that's not available without the Webserver.

Can you check the DB and see the value for:

select value from phplist_config where item = "uploadimageroot";

(0051857)
dubwise259 (reporter)
05-11-12 16:25

I'm sending the queue from the browser using "send test" button.
I've checked the value of the field "uploadimageroot", it was empty so I put the same value as in config.php
Then I send another test message but nothing changed, image appears well because url is correct but message's source code reveals that it is not embedded, only "powerphplist.png" is embedded.
Regards

(0051925)
cmeerendonk (reporter)
28-11-12 14:50

The / is missing between the docroot and uploadimagesdir in function filesystem_image_exists. This should solve it:

diff class.phplistmailer.php.org class.phplistmailer.php
427,428c427,428
< is_file($_SERVER['DOCUMENT_ROOT'].UPLOADIMAGES_DIR.'/image/'.$localfile)
< || is_file($_SERVER['DOCUMENT_ROOT'].UPLOADIMAGES_DIR.'/'.$localfile)
---
> is_file($_SERVER['DOCUMENT_ROOT'].'/'.UPLOADIMAGES_DIR.'/image/'.$localfile)
> || is_file($_SERVER['DOCUMENT_ROOT'].'/'.UPLOADIMAGES_DIR.'/'.$localfile)

(0051926)
michiel (manager)
28-11-12 15:20

thanks for finding that

revision 3483

Notes
(0051814) michiel (manager) 31-10-12 11:22	are you sending your queue with commandline or in-browser? presumably commandline. For commandline, it needs to save the "Image Path" in the DB, because that's not available without the Webserver. Can you check the DB and see the value for: select value from phplist_config where item = "uploadimageroot";

(0051857) dubwise259 (reporter) 05-11-12 16:25	I'm sending the queue from the browser using "send test" button. I've checked the value of the field "uploadimageroot", it was empty so I put the same value as in config.php Then I send another test message but nothing changed, image appears well because url is correct but message's source code reveals that it is not embedded, only "powerphplist.png" is embedded. Regards

(0051925) cmeerendonk (reporter) 28-11-12 14:50	The / is missing between the docroot and uploadimagesdir in function filesystem_image_exists. This should solve it: diff class.phplistmailer.php.org class.phplistmailer.php 427,428c427,428 < is_file($_SERVER['DOCUMENT_ROOT'].UPLOADIMAGES_DIR.'/image/'.$localfile) < \|\| is_file($_SERVER['DOCUMENT_ROOT'].UPLOADIMAGES_DIR.'/'.$localfile) --- > is_file($_SERVER['DOCUMENT_ROOT'].'/'.UPLOADIMAGES_DIR.'/image/'.$localfile) > \|\| is_file($_SERVER['DOCUMENT_ROOT'].'/'.UPLOADIMAGES_DIR.'/'.$localfile)

(0051926) michiel (manager) 28-11-12 15:20	thanks for finding that revision 3483