View Issue Details

IDProjectCategoryView StatusLast Update
0015589phpList 3 applicationSubscriber Importpublic21-06-18 13:05
Reporterkip 
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionsuspended 
Product Version2.10.12 
Target Versionnext majorFixed in Version 
Summary0015589: Successfully imports addresses it later chokes on
DescriptionSo I ran into a really wretched bug yesterday that didn't reveal itself until too late. The email list import feature is very broken and doesn't perform a sanity check on the imported addresses, even when it accepts them. The problem doesn't reveal itself until after the send.

I'm actually using version 2.10.13, but I couldn't find it in the combobox selector.
Steps To Reproduce(1) Click manage users.
(2) Click import users.
(3) Click import emails with the same values for attributes.
(4) Select a text file containing a list of email addresses in the intuitive format:

...
Some Person <somebody@domain.com>
Some Person2 <somebody2@domain.com>
Some Person3 <somebody3@domain.com>
...

(5) Click import.
(6) The emails all import successfully.
(7) When sending out a message, the attempt fails as in the Additional Information section of this bug.

This is due, presumably, to the formatting of the addresses. phpist expects just the email address unbracketed and without a name prefix.

It should have either have issued an error at import or offered to strip out the extraneous characters at that time.
Additional InformationExample processing info log...

...
  listmessage.messageid = 19 and
  listmessage.listid = listuser.listid and
  user.id = listuser.userid and
  usermessage.userid IS NULL
   and user.confirmed and !user.blacklisted
 Found them: 142 to process
 Invalid email: Some Person <somebody@domain.com>, 25
...
TagsNo tags attached.

Activities

michiel

06-06-13 02:54

manager   ~0052104

It seems useful to be able to import emails even invalid ones. At times, a original database does not have the correct details, but they can be added later. So, it's kind of a feature, even though it's still debatable. I don't have strong reasons to change this at this time.