View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015492 | phpList 3 application | Plugin API | public | 27-05-10 19:29 | 29-04-11 20:15 |
| Reporter | adrian15 | Assigned To | |||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | Future developments | ||||
| Fixed in Version | 2.10.14 | ||||
| Summary | 0015492: Rssmanager Rssthreshold greater than fix | ||||
| Description | Whatever the reason the cansend function did not check greater or equal than symbol (>=) but with only greater than symbol (>). So if minimum threshold and maximum threshold was 1 no email at all was sent while it should send 1 email. | ||||
| Additional Information | Based on svn revision 1703. | ||||
| Tags | No tags attached. | ||||
| child of | 0015498 | new | phpList 3 plugins | Rss manager is totally broken on svn |
|
27-05-10 19:29
|
G04_rssmanager_rssthreshold_greater_than_fix.patch (888 bytes)
diff -urN rssfixes_G03_rssmanager_iWantToProcess_function/lists/admin/plugins/rssmanager.php rssfixes_G04_rssmanager_rssthreshold_greater_than_fix/lists/admin/plugins/rssmanager.php
--- rssfixes_G03_rssmanager_iWantToProcess_function/lists/admin/plugins/rssmanager.php 2010-05-17 07:04:19.000000000 +0200
+++ rssfixes_G04_rssmanager_rssthreshold_greater_than_fix/lists/admin/plugins/rssmanager.php 2010-05-17 07:19:28.000000000 +0200
@@ -228,7 +228,7 @@
if ($userdata['rssfrequency'] == $messagedata["rsstemplate"]) {
$rssitems = rssmanager::rssUserHasContent($userdata['id'],$messagedata['id'],$userdata['rssfrequency']);
$threshold= sprintf('%d',getConfig("rssthreshold"));
- $cansend = sizeof($rssitems) && (sizeof($rssitems) > $threshold);
+ $cansend = sizeof($rssitems) && (sizeof($rssitems) >= $threshold);
} else {
$cansend = false;
}
|
