View Issue Details

IDProjectCategoryView StatusLast Update
0015492phplist applicationPlugin APIpublic29-04-11 19:15
Reporteradrian15 
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Product VersionFutureDevelopments 
Target VersionFixed in Version2.10.14 
Summary0015492: Rssmanager Rssthreshold greater than fix
DescriptionWhatever the reason the cansend function did not check greater or equal than symbol (>=) but with only greater than symbol (>).

So if minimum threshold and maximum threshold was 1 no email at all was sent while it should send 1 email.
Additional InformationBased on svn revision 1703.
TagsNo tags attached.

Relationships

child of 0015498 new rssmanager Rss manager is totally broken on svn 

Activities

27-05-10 18:29

 

G04_rssmanager_rssthreshold_greater_than_fix.patch (888 bytes)
diff -urN rssfixes_G03_rssmanager_iWantToProcess_function/lists/admin/plugins/rssmanager.php rssfixes_G04_rssmanager_rssthreshold_greater_than_fix/lists/admin/plugins/rssmanager.php
--- rssfixes_G03_rssmanager_iWantToProcess_function/lists/admin/plugins/rssmanager.php	2010-05-17 07:04:19.000000000 +0200
+++ rssfixes_G04_rssmanager_rssthreshold_greater_than_fix/lists/admin/plugins/rssmanager.php	2010-05-17 07:19:28.000000000 +0200
@@ -228,7 +228,7 @@
     if ($userdata['rssfrequency'] == $messagedata["rsstemplate"]) {
       $rssitems = rssmanager::rssUserHasContent($userdata['id'],$messagedata['id'],$userdata['rssfrequency']);
       $threshold= sprintf('%d',getConfig("rssthreshold"));
-      $cansend = sizeof($rssitems) && (sizeof($rssitems) > $threshold);
+      $cansend = sizeof($rssitems) && (sizeof($rssitems) >= $threshold);
     } else {
       $cansend = false;
     }