View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015484 | phpList 3 plugins | [All Projects] General | public | 20-05-10 16:34 | 06-02-19 11:35 |
| Reporter | adrian15 | ||||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | new | Resolution | open | ||
| Summary | 0015484: Editlist generates a database error connection when saving | ||||
| Description | While debugging rss plugin in svn revision 1703 I found that when saving a list there was always a database error connection. I suppose that when there was an error when saving a list the list might appear as correctly saved, so this is another bug... but it is just a supposition at looking at the code very fast. The error might appear non-existant at first glance because it appears just before redirecting to list page. In my test code I had commented the: Redirect('list'); line. | ||||
| Additional Information | Found on SVN 1703 but it also applies to current (2010/05/20) svn (have seen the same code there) | ||||
| Tags | No tags attached. | ||||
| child of | 0015498 | new | Rss manager is totally broken on svn |
|
20-05-10 16:34
|
G01_hidden_database_error_editlist.patch (817 bytes)
diff -urN saidi/lists/admin/editlist.php rssfixes_G01_hidden_database_error_editlist/lists/admin/editlist.php
--- saidi/lists/admin/editlist.php 2010-04-27 17:36:50.000000000 +0200
+++ rssfixes_G01_hidden_database_error_editlist/lists/admin/editlist.php 2010-05-16 17:52:04.000000000 +0200
@@ -69,11 +69,11 @@
. ' values'
. ' (?, ?, current_timestamp, ?, ?, ?, ?)';
$query = sprintf($query, $tables['list']);
- }
-# print $query;
- $result = Sql_Query_Params($query, array($_POST['listname'],
+ $result = Sql_Query_Params($query, array($_POST['listname'],
$_POST['description'], $_POST['listorder'], $_POST['owner'],
$_POST['prefix'], $_POST['active']));
+ }
+# print $query;
if (!$id)
$id = Sql_Insert_Id($tables['list'], 'id');
## allow plugins to save their fields
|
|
|
This is the other bug that this patch fixes (The bug that I was initially trying to fix): The processEditList hook that plugins should run at editlist page is not called at all. I am going to convert this into a major bug because it is actually a plugins lack of functionality. If someone has the rights please move this issue into plugins category. Thank you. |
|
|
Please convert (the person who has the rights) this bug into a major one. (It seems I cannot change my bugs priority.) Thank you. |
|
|
Please change target version to 2.11.WHATEVER. In order to solve the bug I had a look at 2.10.12 code so that I understood what was supposed to do the whole piece of code. 2.10.12 is ok and does not have this bug so there is no need of fixing anything in 2.10.13. Thank you for having changed the bug to the appropiated category and its severity. |
|
|
Thanks for clarifying that. Changed target to 2.11.4 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 20-05-10 16:34 | adrian15 | New Issue | |
| 20-05-10 16:34 | adrian15 | File Added: G01_hidden_database_error_editlist.patch | |
| 20-05-10 16:46 | adrian15 | Note Added: 0051018 | |
| 20-05-10 16:47 | adrian15 | Note Added: 0051019 | |
| 20-05-10 20:59 | h2b2 | Severity | minor => major |
| 20-05-10 20:59 | h2b2 | Category | Interface - Backend => Plugin API |
| 20-05-10 20:59 | h2b2 | Target Version | => 2.10.13 |
| 20-05-10 22:35 | adrian15 | Note Added: 0051021 | |
| 21-05-10 01:55 | h2b2 | Note Added: 0051022 | |
| 21-05-10 01:55 | h2b2 | Target Version | 2.10.13 => 2.11.4 |
| 21-05-10 01:56 | h2b2 | Note Edited: 0051022 | |
| 27-05-10 19:05 | h2b2 | Relationship added | child of 0015498 |
| 23-05-12 02:20 | michiel | Project | phpList 3 application => rssmanager |
| 23-05-12 02:20 | michiel | Category | Plugin API => General |
| 06-02-19 11:35 | erion | Project | rssmanager => phpList 3 plugins |
