View Issue Details

IDProjectCategoryView StatusLast Update
0015399phplist applicationSubscriber Importpublic03-06-13 21:44
ReporterJeff DDG 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.10.10 
Target Version4.0.xFixed in Version2.11.11 
Summary0015399: include_once statement inside import loop in import1.php
DescriptionOn line 208 of import1.php, you have:

include_once dirname(__FILE__)."/commonlib/lib/userlib.php";

This is inside the main import loop and could slow things down for big imports. Also, on line 206, you have:

mt_srand((double)microtime()*1000000);

This is also inside the loop. Both of these could be moved prior to line 177, to make the import more efficient. The mt_srand() call isn't even necessary. The mt_rand() function doesn't need to be initialized with a salt value like rand() does.

Simple tweaks, nothing big. Still reading through the code... :)

--jeff
TagsNo tags attached.

Activities

There are no notes attached to this issue.