phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015303phplist applicationMessage Send Processpublic09-06-09 21:4027-11-09 18:06
Reportertipichris 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version2.10.10 
Target VersionFixed in Version2.10.11 
Summary0015303: Signatures added twice, and in invalid ways
DescriptionIf an HTML template includes a [SIGNATURE] placeholder, the signature is added both at the place holder and appended to the end of the message. Additionally, if the template includes the complete HTML, the appended signature is added after the closing </html> tag.

The following patch resolves these issues:

--- lists/admin/sendemaillib.php.orig Sun May 31 21:58:10 2009
+++ lists/admin/sendemaillib.php Tue Jun 9 20:28:03 2009
@@ -239,7 +239,7 @@

 ## Parse placeholders
   #0013076: Blacklisting posibility for unknown users
- foreach (array("forwardform","subscribe","preferences","unsubscribe","signature", 'blacklist') as $item) {
+ foreach (array("forwardform","subscribe","preferences","unsubscribe", 'blacklist') as $item) {
     if (eregi('\['.$item.'\]',$htmlmessage,$regs)) {
       $htmlmessage = eregi_replace('\['.$item.'\]',$html[$item],$htmlmessage);
 // unset($html[$item]); //ASK: Why was this done? It breaks placeholders in the footer
@@ -301,7 +301,7 @@
   if (eregi("\[SIGNATURE\]",$htmlmessage))
     $htmlmessage = eregi_replace("\[SIGNATURE\]",$html["signature"],$htmlmessage);
   elseif ($html["signature"])
- $htmlmessage .= '
'.$html["signature"];
+ $htmlmessage = addHTMLFooter($htmlmessage, '
'. $html["signature"]);
   if (eregi("\[FOOTER\]",$textmessage))
     $textmessage = eregi_replace("\[FOOTER\]",$text["footer"],$textmessage);
   else
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to 0015395resolvedmichiel [BLACKLIST] doesn't produce link in message footer 
child of 0015369resolvedmichiel 2.10.10 initial patches 

-  Notes
(0050732)
h2b2 (manager)
30-08-09 18:20

I can confirm that the above patch solves the issue of an additional signature in the footer.

A patched lists/admin/sendemaillib.php file (for v2.10.10) can be found in this forum post: http://forums.phplist.com/viewtopic.php?f=17&t=24827&p=67555#p67555 [^]
(0050789)
michiel (manager)
27-11-09 18:06

revision 1702


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker