phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015286phplist applicationBounce Managementpublic12-05-09 18:0127-11-09 17:28
Reporternickyoung 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version2.10.10 
Target Version2.10.11Fixed in Version2.10.11 
Summary0015286: delete bounce operation doesn't work from 'view a bounce' page
DescriptionI just upgraded to 2.10.10.

Now when I go to the "View a bounce" page from the admin and then with "Delete this bounce and go to the next" checked, hit the "Do the above" button, the page refreshes and the bounce doesn't appear to be deleted.
TagsNo tags attached.
Attached Files

- Relationships
has duplicate 0015413resolved "Delete user" and "delete bounce and go to next" doesn't work 
has duplicate 0015296resolved Cannot increase bounce count manually 
child of 0015369resolvedmichiel 2.10.10 initial patches 
child of 0015370resolvedmichiel svn revision 1703 inspired from 2.10.10 initial patches 

-  Notes
(0050643)
nickyoung (reporter)
12-05-09 18:51

It appears that the $deletebounce variable is not initialized from $_GET so it is always empty.
(0050644)
nickyoung (reporter)
12-05-09 18:59

I fixed this issue by adding this at line 18 of admin/bounce.php:

$deletebounce = isset($_GET["deletebounce"]) ? $_GET["useremail"] : '';

I don't know if this is the proper place to put the fix but it seems to work.
(0050645)
nickyoung (reporter)
12-05-09 19:00

oops, typo: line 18 should be this:


$deletebounce = isset($_GET["deletebounce"]) ? $_GET["deletebounce"] : '';
(0050650)
nickyoung (reporter)
15-05-09 19:03

Note, I also found that $deleteuser is not initialized from $_GET so you can't delete a user from the view a bounce page
(0050717)
h2b2 (manager)
28-08-09 05:16

Can confirm the issue. Actually none of the options on the 'View a bounce' page seem to work:

- Increase bouncecount with
- Mark user as unconfirmed
- Set user to receive text instead of HTML
- Delete user
- Delete this bounce and go to the next
(0050718)
h2b2 (manager)
28-08-09 05:17

Related forum thread: http://forums.phplist.com/viewtopic.php?f=17&t=24559 [^]
(0050730)
CS2 (reporter)
30-08-09 06:03

I have not confirmed, but looking over the code a bit, I think that expanding on nickyoung's sleuthing to add the following lines should fix the remaining issues:

$amount = isset($_GET["amount"]) ? $_GET["amount"] : '';
$unconfirm = isset($_GET["unconfirm"]) ? $_GET["unconfirm"] : '';
$maketext = isset($_GET["maketext"]) ? $_GET["maketext"] : '';
$deleteuser = isset($_GET["deleteuser"]) ? $_GET["deleteuser"] : '';
(0050731)
h2b2 (manager)
30-08-09 14:09

-
Inserted the code suggested by nickyoung and CS2 at line 18 of lists/admin/bounce.php and ran a quick test. All options seem to be working now. Thanks!

Will add the fixed bounce.php to the list of patched files in http://forums.phplist.com/viewtopic.php?f=9&t=24494#p66892 [^]
(0050785)
michiel (manager)
27-11-09 17:28

revision 1696


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker