View Issue Details

IDProjectCategoryView StatusLast Update
0015261phpList 3 applicationAdmin Managementpublic19-11-19 22:33
Reporterlwc 
PrioritynormalSeveritytrivialReproducibilityalways
Status assignedResolutionreopened 
Product VersionFuture developments 
Target VersionFixed in Version3.0.X 
Summary0015261: Silent blacklisting
DescriptionYou have to realize there's a HUGE difference between a user blacklisting himself/herself and one who requests (read: demands) the admin to do it for him/her. The last thing in the world you or the latter type of user wants is yet ANTOHER message, which could bring you more troubles.

A temporal solution is doing this in admin/lib.php, just while silent blacklisting:

function sendMail (...

/*
  if ($GLOBALS['usephpmailer']) {
    return sendMailPhpMailer($to,$subject,$message);
  } else {
    return sendMailOriginal($to,$subject,$message,$header,$parameters);
  }
*/

So please just do something like this:

if (this is the actual user removing himself/herself) {
  if ($GLOBALS['usephpmailer']) {
    return sendMailPhpMailer($to,$subject,$message);
  } else {
    return sendMailOriginal($to,$subject,$message,$header,$parameters);
  }
}
Additional InformationSuch blacklisting still takes lots of time for phplist to acknowledge it.

You'd think the trouble comes from blacklist_gracetime, but this doesn't seem to make any difference whatsoever:

// custom code - start
$GLOBALS["blacklist_gracetime"] = 1;
// custom code - end
  if (!$skipblacklistcheck && isBlackListed($to)) {
...

http://forums.phplist.com/viewtopic.php?t=23805
TagsNo tags attached.

Relationships

related to 0005184 new manual blacklisting 

Activities

lwc

23-04-09 08:57

updater   ~0050624

Here's the patch plus the "something like this" part:

function sendMail (...

// custom code - start
// Only send confirmations for self removals
if (!isset($_SESSION["adminloggedin"]) || !$_SESSION["adminloggedin"]) {
// custom code - end
  if ($GLOBALS['usephpmailer']) {
    return sendMailPhpMailer($to,$subject,$message);
  } else {
    return sendMailOriginal($to,$subject,$message,$header,$parameters);
  }
// custom code - start
}
// custom code - end

But I still need a way to remove (or at least lower) the gracetime for removals by admins.

Thorsten Albrecht

11-08-09 10:54

reporter   ~0050710

To put a user silently to the blacklist by the admin, I applied the following solution:

http://forums.phplist.com/viewtopic.php?f=16&t=6121&start=15

Thorsten

michiel

19-04-10 16:59

manager   ~0050924

the dev version has this option in the backend

http://dev.phplist.com/lists/admin/?page=massunconfirm

lwc

08-10-13 09:08

updater   ~0052313

(Mass) unconfirm is not the same as blacklisting.
Unconfirm means this address is invalid and/or belongs to someone else.
Blacklisting means you know exactly who this is, but they don't want to get messages.
Thus you shouldn't unconfirm someone just to blacklist them.

In the current version (3), does it inform the user if the admin gets in the user's listing and click to blacklist them? If *not*, you can signal this as fixed, but this time under the right circumstances.

michiel

08-10-13 14:23

manager   ~0052320

too many negatives makes my head dazzle. but subscribers are not informed when the admin uses this page to unconfirm or blacklist them.

Please note, this page will unconfirm the subscribers entered, except when the checkbox "Make suppression permanent" is checked in which case it will blacklist them.

lwc

08-10-13 15:59

updater   ~0052330

I've checked this and permanent mass unconfirm not only blacklists users but also unconfirms them.

But also, does v3 inform the user if the admin gets in the user's listing and click to blacklist them? If *not*, you can signal this as fixed and I'll open a different ticket about the former issue.