phplist

NOTE:: Before reporting an issue, make sure you are running the latest version, currently 3.3.1


View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015223phplist applicationMessage Send Processpublic30-01-09 01:5202-11-12 12:51
Reporterjudgej 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version2.10.8 
Target Version4.0.xFixed in Version2.11.8 
Summary0015223: "Processed N out of M users" counts are incorrect.
DescriptionThis is something that I think has been wrong for as long as I have known PHPlist - at least five years. I've only just put my finger on it though.

The mailing process counts have always confused me, and I have not been able to make sense of them. Here is an example:

[Fri 30 Jan 2009 01:28] [82.39.210.203] Processing message 15
[Fri 30 Jan 2009 01:28] [82.39.210.203] Looking for users
[Fri 30 Jan 2009 01:28] [82.39.210.203] Found them: 1 to process
[Fri 30 Jan 2009 01:29] [82.39.210.203] Processed 1 out of 1 users
[Fri 30 Jan 2009 01:29] [82.39.210.203] It took 5 mins 1 secs to send this
message
[Fri 30 Jan 2009 01:29] [82.39.210.203] Processing message 18
[Fri 30 Jan 2009 01:29] [82.39.210.203] Looking for users
[Fri 30 Jan 2009 01:29] [82.39.210.203] Found them: 1 to process
[Fri 30 Jan 2009 01:29] [82.39.210.203] Processed 2 out of 1 users *
[Fri 30 Jan 2009 01:29] [82.39.210.203] It took 3946 hours 29 mins 58 secs
to send this message
[Fri 30 Jan 2009 01:29] [82.39.210.203] Processing message 26
[Fri 30 Jan 2009 01:29] [82.39.210.203] Looking for users
[Fri 30 Jan 2009 01:29] [82.39.210.203] Found them: 1 to process
[Fri 30 Jan 2009 01:29] [82.39.210.203] Processed 3 out of 1 users *

The system seems to be able to process more users than there are to process (note the lines marked with an asterisk). The reason is that the count displayed is not reset for each message loop.
Additional InformationMy solution is to move this code from 324:

$notsent = $sent = $invalid = $unconfirmed = $cannotsend = 0;

To within the message loop on line 354, just after this:

$failed_sent = 0;

I am not sure if resetting those counts each message loop has other undesirable effects, and if so, perhaps separate count that *is* reset can be used just for generating the message "Processed N out of M users".
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0050331)
judgej (reporter)
30-01-09 15:22

Forgot to mention: the file referred to in this bug is lists/admin/processqueue.php


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker