View Issue Details

IDProjectCategoryView StatusLast Update
0014762phpList 3 pluginsGeneralpublic06-02-19 11:35
Reporterflohack Assigned To 
Status newResolutionopen 
Summary0014762: RSS-Messages get wrong embargo time
Descriptionafter a few months of running without this problem, messages are suddenly rewritten with the wrong embargo time (end of job + frequency instead of beginning of job + frequency).
the other day the cron job finds a message still on hold, as the embargo is not reached and skips the submission.
Additional InformationOur investiagtion in the PHP code discovered the cause of the problem (or the sympton?): The embargo is set to either old_embargo + frequency or now() + frequency on the end of the queue run. based on a flag isfuture, the decision is wrongly made for the second option, as the condition "date_add(embargo,interval repeatinterval minute) > now() as isfuture" is always true. newembargo is calculated: "date_add(embargo,interval repeatinterval minute)", and newembargo2 as "date_add(now(),interval repeatinterval minute)"
then there are some lines not connected with this code, finally:

# correct some values
        if (!$msgdata["isfuture"]) {
                $msgdata["newembargo"] = $msgdata["newembargo2"];

this is bad coding style, not connected with the first few lines which actually calculate these values, and the whole construct is simply not correct. The clause should be IMHO "date_add(embargo,interval repeatinterval minute) < now()", then an incorrect embargo would be detected, and the normal case would be handled as it should be.

thanks for reading up to here.
TagsNo tags attached.


related to 0014115 new rsslib.php: user send check compares interval too strict 


There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
30-05-08 11:38 flohack New Issue
30-05-08 15:10 user3543 Severity major => tweak
30-05-08 15:10 user3543 Projection none => tweak
30-05-08 15:10 user3543 Target Version => 2.11.4
02-06-10 01:00 h2b2 Relationship added related to 0014115
04-06-13 11:14 michiel Project phpList 3 application => rssmanager
04-06-13 11:14 michiel Category Repetition => General
06-02-19 11:35 erion Project rssmanager => phpList 3 plugins