Dependency Graph View Issue Relation Graph Vertical
related to child of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
0019184phpList 3 applicationGeneralpublic13-02-19 12:28
Reporterduncanc 
PriorityurgentSeveritymajorReproducibilityhave not tried
Status assignedResolutionopen 
Product Version3.3.2-RC3 
Target VersionFixed in Version 
Summary0019184: 3.3.2-RC4 appears to be incorrecly built
DescriptionI noticed 3.3.2-RC4 on Sourceforge. Running diff to compare with RC3 shows what appear to be regressions, presumably to RC2, e.g. lots of changes of $GLOBALS['i18N']->get() to s() are now undone:

diff -r lists_3.3.2-RC3/admin/list.php lists_3.3.2-RC4/admin/list.php
95c95
< echo '<div class="pull-right">'.PageLinkButton('editlist', s('Add a list')).'</div>';
---
> echo '<div class="pull-right">'.PageLinkButton('editlist', $GLOBALS['I18N']->get('Add a list')).'</div>';
99c99
< echo '<div class="pull-right">'.PageLinkButton('editlist', s('Add a list')).'</div>';
---
> echo '<div class="pull-right">'.PageLinkButton('editlist', $GLOBALS['I18N']->get('Add a list')).'</div>';

Maybe a pull request based on an out of date master has been merged, with the effect of undoing other changes.
TagsNo tags attached.

Activities

michiel

17-04-18 17:57

manager   ~0060413

I created RC4 from the release-3.3.2 branch, which is now quite a lot behind master. We're almost ready to go 3.3.3-RC1 on master.

I think that accounts for the differences, but testing should clarify that.

FYI @samtuke

michiel

18-04-18 21:34

manager   ~0060424


If testing of 3.3.2-RC4 passes, we should release it asap. It's been too long now. Then we can concentrate on 3.3.3 and do it a bit quicker than 3.3.2

We've had a lot of activity on 3.3.3 so it will be a big update.

It is all pending on finalising the test and then getting the announcements ready to go out.

FYI @samtuke