|Relationship Graph||View Issue Dependency Graph|
View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0016788||phpList 3 plugins||[All Projects] General||public||19-05-13 17:26||11-06-13 12:50|
|Summary||0016788: Not able to send a message to subscribers who previously were excluded|
|Description||Using the simple criteria plugin to choose users based on a select attribute.|
Rows are added to the usermessage table with a status of 'not sent' for subscribers who are not selected.
If I then amend a subscriber to have the "correct" attribute value and resend the message then that user is not selected, due to the existing row in usermessage.
This is not consistent with resending the message after adding a new subscriber. In that case the new subscriber would be selected.
The sql at line 730 of admin/actions/processqueue.php possibly needs to be amended to include those rows in usermessage with status 'not sent'.
But there may be other reasons why the status is 'not sent' and which should not be included.
|Tags||No tags attached.|
||is that when using the phplist-plugin-attributeselect plugin?|
Interesting. Preferably, we would record the reason, and possibly the plugin blocking the send at the moment of marking the "not sent", so that this can be cleared again with a call to the plugin (ie a plugin can clear it's own blocks).
At the moment, "not sent" can have many reasons, marked with "cansend" being false. Eg the RSS plugin may decide not to send a mail, because there are not sufficient RSS entries to send. The next time it will, and we do not want to duplicate messages.
There is a "failure_reason" variable keeping track.
I'll have a think about how to deal with this. Just wiping all entries "not sent" before sending seems a sledgehammer, and may have a big undesired performance impact.
Yes, I am using that plugin.
The approach now is different to that in 2.10.x, whereby the criteria are used to find possible users and the results of that are then included in the main query to find users (the equivalent of the sql at line 730).
Maybe revert to that approach, allow the plugin to provide some sql that is used as a subquery to filter the selected users. That sql is in effect the result of the method subscriberSelection() in simpleattributeselect.
The result should be that rows are added to usermessage only for those users who are actually sent the message.
The rows in usermessage with status 'not sent' are introducing errors in user and message statistics.
The user page shows the number of messages sent to the user, and that is including the 'not sent' rows from usermessage.
The stats overview page is also including the 'not sent' users.
||hmm, yes, it obviously needs work.|
||I think this should be dealt with by the plugin. It should clear the entries that were "not sent" before re-applying the selection.|
|19-05-13 17:26||duncanc||New Issue|
|19-05-13 22:54||michiel||Note Added: 0052038|
|20-05-13 01:10||michiel||Note Added: 0052039|
|20-05-13 07:56||duncanc||Note Added: 0052040|
|20-05-13 09:42||duncanc||Note Added: 0052041|
|20-05-13 09:43||duncanc||Note Edited: 0052041||View Revisions|
|20-05-13 15:33||michiel||Note Added: 0052044|
|20-05-13 15:33||michiel||Target Version||=> 2.11.10|
|25-05-13 19:24||michiel||Relationship added||related to 0016587|
|29-05-13 15:35||michiel||Issue cloned: 0016796|
|29-05-13 15:35||michiel||Relationship added||related to 0016796|
|04-06-13 19:39||michiel||Relationship added||related to 0005521|
|07-06-13 20:49||michiel||Note Added: 0052108|
|07-06-13 20:49||michiel||Target Version||2.11.10 => 2.11.X|
|11-06-13 12:50||michiel||Project||phpList 3 application => phpList 3 plugins|
|11-06-13 12:50||michiel||Category||Message Send Process => General|